Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace the LeetCode.svg and LeetCode.png #419

Merged
merged 2 commits into from
Sep 16, 2019

Conversation

poppinlp
Copy link
Contributor

@poppinlp poppinlp commented Sep 16, 2019

  • Replace the LeetCode.svg and LeetCode.png
  • Add JIEJIAN21 in contributors
  • Seems my markdown plugin reformated the table in README.md to make the separator in the same column.

Address #401

@jdneo
Copy link
Member

jdneo commented Sep 16, 2019

Thanks @poppinlp, could you fix the CI error?

ERROR Images in README.md must come from an HTTPS source: ./resources/LeetCode.png

@poppinlp
Copy link
Contributor Author

poppinlp commented Sep 16, 2019

This error is occured by the url of LeetCode.png in README.md and README_zh-CN.md.
I've modified the url to local relative path instead of the file from master branch of github repository.

Actually, I think it's good to use relative path here since we should use the resources from current branch. But seems vsce dose not support it right now according to this issue.

I've changed it back to pass the travis CI.

@jdneo jdneo merged commit 237e56f into LeetCode-OpenSource:master Sep 16, 2019
@jdneo
Copy link
Member

jdneo commented Sep 17, 2019

Hey @poppinlp

Just one more question. Now the extension icon and the activity bar icon are both using the new picture. Are we mean to discard the activity bar icon that your friend designed just before?

@poppinlp poppinlp deleted the new_logo branch September 17, 2019 03:10
@poppinlp
Copy link
Contributor Author

I think I made a mistake. I should only replace the image in README. The previous activity icon is much more fits the sidebar. I'll bring it back now.
image

@jdneo jdneo added this to the 0.15.5 milestone Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants