Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: star command in shortcuts #601

Merged
merged 3 commits into from Jul 21, 2020
Merged

add: star command in shortcuts #601

merged 3 commits into from Jul 21, 2020

Conversation

yihong0618
Copy link
Contributor

@jdneo @zry656565
Support star/unstar in codelen shortcuts/
image

@yihong0618
Copy link
Contributor Author

Support #598 #549

@jdneo
Copy link
Member

jdneo commented Jul 20, 2020

Thanks @yihong0618

I would suggest to use $(star-empty) and $(star-full). You can find the style here: https://microsoft.github.io/vscode-codicons/dist/codicon.html

@yihong0618
Copy link
Contributor Author

@jdneo
Seems a bit low then the text title(Submit, Test)?
And is it necessary to change heart icon to star icon too?
image

@jdneo
Copy link
Member

jdneo commented Jul 20, 2020

Ok, given the current rendering result, seems using text is better. But I think there is no need to put it as one of the default value

@yihong0618
Copy link
Contributor Author

Ok, given the current rendering result, seems using text is better. But I think there is no need to put it as one of the default value

Maybe in setting that user can config it open it or not?

@jdneo
Copy link
Member

jdneo commented Jul 20, 2020

Do you mean using a setting to toggle between text and icon?

@yihong0618
Copy link
Contributor Author

Do you mean using a setting to toggle between text and icon?

Forget it, I think for now, keep the text maybe a better way.

@jdneo
Copy link
Member

jdneo commented Jul 20, 2020

I think so too.

package.json Outdated
@@ -621,7 +621,8 @@
"type": "array",
"default": [
"submit",
"test"
"test",
"star"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add this shortcut by default. But please add it in the items, and also documents in readme

@yihong0618
Copy link
Contributor Author

@jdneo Fixed.

README.md Outdated
- `Submit`: Submit your answer to LeetCode.
- `Test`: Test your answer with customized test cases.
- `Star/Unstar`: Star or Unstar the current problem.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: unstar

@@ -629,6 +629,7 @@
"enum": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you by the way add "enumDescriptions" for this setting here? 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, and optimize star logic.

Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yihong0618 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants