Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Norwegian Nynorsk translation #1102

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Conversation

huftis
Copy link
Contributor

@huftis huftis commented Jul 27, 2023

Here‘s a complete translation of Jerboa into Norwegian Nynorsk.

I have a question about some of the sorting strings, though. They look like this:

NewComments
TopMonth
TopSixHour

They look like internal, machine-readable strings, which should not be translated or translatable, i.e., should not be present in strings.xml. Are they included by mistake?

I did, however, translate them (as similar machine-friendly strings), as I see they are translated in string files for the other languages.

Note that there are also corresponding ‘human-friendly’ strings included, e.g., ‘New Comments’ and ‘Top Month’. And these are the ones actually used in the UI. One exception is TopAll, which doesn’t have a human-friendly version in (‘Top All’) in strings.xml. And in the UI in the app, the option is indeed listed as ‘TopAll’, while all the other sorting options are listed using the human-friendly versions.

@MV-GH
Copy link
Collaborator

MV-GH commented Jul 27, 2023

They are included and visible to the user, It is just a shorter version of the longer names on places where we have less screen real estate.

@huftis
Copy link
Contributor Author

huftis commented Jul 27, 2023

They are included and visible to the user, It is just a shorter version of the longer names on places where we have less screen real estate.

OK. Though it looks like a ‘Top All’ string is missing at
https://github.com/dessalines/jerboa/blob/main/app/src/main/java/com/jerboa/Utils.kt#L1117

That is, MAP_SORT_TYPE_LONG_FORM reuses the R.string.sorttype_topall (TopAll) string instead of having a long-form R.string.dialogs_top_all string.

@MV-GH
Copy link
Collaborator

MV-GH commented Jul 27, 2023

It indeed does, you can add it if you want

@MV-GH
Copy link
Collaborator

MV-GH commented Jul 27, 2023

image
Pipeline having issues,

@MV-GH MV-GH enabled auto-merge (squash) July 27, 2023 14:58
@MV-GH MV-GH merged commit 03627ea into LemmyNet:main Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants