Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigating to other instance communities and users #413

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

Anna-log7
Copy link
Contributor

@Anna-log7 Anna-log7 commented Jun 4, 2023

This fixes an issue where the app crashes/restarts when a user or community in a different instance is clicked within a comment.
I've changed the routes slightly so the name given ends up being name@instance instead of just name

Fixes #395

@Anna-log7 Anna-log7 force-pushed the instance-deeplink-fix branch 2 times, most recently from f84b9d9 to c1e012c Compare June 4, 2023 22:56
@Anna-log7
Copy link
Contributor Author

So I've got this building/running with no issues, but it looks like the pipeline is failing. I'd love to fix the issue, but I don't love giving read access to my private repos. Is there a way I can get around that requirement to log in with my account?

@dessalines
Copy link
Member

I don't think so, not with woodpecker at least. Run ./gradlew formatKotlin to pass the lint.

@dessalines dessalines enabled auto-merge (squash) June 5, 2023 16:09
auto-merge was automatically disabled June 5, 2023 16:26

Head branch was pushed to by a user without write access

@dessalines dessalines merged commit ff3c0d0 into LemmyNet:main Jun 5, 2023
@Anna-log7 Anna-log7 deleted the instance-deeplink-fix branch June 5, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes when navigating to linked communities in other instances
2 participants