Bash isn't portable, use POSIX sh instead #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why comment the unused variable? If truly unused removal should be okay. Commenting implicates that it might be relevant in certain conditions which might lead other devs to search for the "when is it relevant". |
I am not the original author of this script, it's not for me to decide. Maybe they will remember what they wanted to do with it and finish it. If I remove it, they might forget entirely. |
|
I say just remove it, I don't think there was some larger intent here. |
|
I mean, anyway, @dessalines wrote that line according to the git blame, so he will say something if it's meant to stay. |
7heo
force-pushed
the
main
branch
2 times, most recently
from
187c808
to
af77522
Compare
Also, hardcoding bash to /bin/bash is even less portable. In addition, I removed an unused variable (name not present anywhere in the code base, not exported) and the related comments.
dessalines
approved these changes
Jun 13, 2023
| set -e | ||
|
|
||
| port=$1 | ||
|
|
There was a problem hiding this comment.
Was fine to remove, its unecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, hardcoding bash to /bin/bash is even less portable.
In addition, I commented an unused variable (name not present anywhere in the code base, not exported).