Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Settings: Improves paddings and small layout details #612

Merged

Conversation

sabieber
Copy link
Contributor

Before

Before After

This increases the spacing to the edges of the screen.
It also unifies the spacings between text fields and their headings.
This results in a more unified look even when checkbox labels differ a lot in length.
@twizmwazin
Copy link
Contributor

Run ./gradlew formatKotlin to fix the formatting issues

@dessalines
Copy link
Member

This entire page was written by someone else, and needs to be replaced with alorma:compose-settings at some point.

@sabieber
Copy link
Contributor Author

Run ./gradlew formatKotlin to fix the formatting issues

Thanks for the hint, pushed a commit and will try to configure Android Studio to adhere to the settings

@sabieber
Copy link
Contributor Author

This entire page was written by someone else, and needs to be replaced with alorma:compose-settings at some point.

Maybe this could be merged and I could rework the view while using alorma afterwards? Think the commits already bring some improvements over the current state of the screen.

@twizmwazin
Copy link
Contributor

Yeah I agree with that approach. The work is done to make this small improvement, let's merge it and then hopefully the next change will be rewriting it properly.

@dessalines dessalines merged commit 63623cc into LemmyNet:main Jun 14, 2023
@sabieber sabieber deleted the feature/sbi/account-settings-layout branch June 14, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants