Quick comment navigation #749
Conversation
# Conflicts: # app/src/main/java/com/jerboa/MainActivity.kt # app/src/main/java/com/jerboa/ui/components/post/PostActivity.kt # app/src/main/res/values/strings.xml
There was a problem hiding this comment.
Solve conflicts, then I'll check this out.
Random thought, but do you think in addition to volume button, a floating action button would work well too?
cc @twizmwazin
# Conflicts: # app/src/main/java/com/jerboa/db/AppDB.kt # app/src/main/java/com/jerboa/ui/components/person/PersonProfileActivity.kt # app/src/main/java/com/jerboa/ui/components/post/PostActivity.kt
|
@dessalines Thanks, I think this is ready now. Do you mean a floating action button instead of the two buttons added in the BottomAppBar? It looks like this currently.
|
There was a problem hiding this comment.
Nice job, everything works well.
My gut feeling was initially that maybe the index tracker should exist on CommentNodes rather than Post, but considering it should only ever be seen from the post page, and not on other comment lists, its probably better this way.
| }, | ||
| bottomBar = { | ||
| if (showParentCommentNavigationButtons) { | ||
| BottomAppBar( |
There was a problem hiding this comment.
Externalize this somewhere, probably in ui/common/appbars
There was a problem hiding this comment.
Should I move scrollToNextParentComment and scrollToPreviousParentComment to Utils as well?
https://github.com/dessalines/jerboa/pull/749/files/573a154d6cb52b624803dc5530a91501d168576a#diff-9958f04ae114c8444c9e781405889c7fab0b5465ca616011fcfb047a243c356bR579
They will be referenced in both the external BottomAppBar and the volume button key event
| Icon( | ||
| modifier = Modifier.scale(1.5f), | ||
| imageVector = Icons.Filled.KeyboardArrowUp, | ||
| contentDescription = "Up", |
There was a problem hiding this comment.
Use i18n strings, lots of examples in this file.
| Icon( | ||
| modifier = Modifier.scale(1.5f), | ||
| imageVector = Icons.Filled.KeyboardArrowDown, | ||
| contentDescription = "Down", |
A floating action button would be more material-y, but I don't think that's necessarily what users prefer. This feature is an example of porting over a feature users have grown used to using in other apps, and I think in those cases it's important to replicate the UI that they want above all else. If someone wants it we can always add it in the future as an extra option. |
- i18n comment arrow descriptions - move CommentNavigationBottomAppBar to AppBars.kt
# Conflicts: # app/src/main/java/com/jerboa/ui/components/common/AppBars.kt # app/src/main/java/com/jerboa/ui/components/post/PostActivity.kt
|
I'm noticing a bug where enabling volume button navigation breaks swiping to go back to the previous page, so I need to look into that |
|
@dessalines Ready for another look, thank you |
This adds two buttons to the bottom of the Post activity for quick parent comment navigation (#542), as well as a Look and Feel setting to toggle them (enabled by default).
It also allows for parent comment navigation with volume buttons. This setting is disabled by default.
device-2023-06-18-230927.webm