Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rough rudimentary CONTRIBUTING.md #753

Merged
merged 10 commits into from
Jun 19, 2023
Merged

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented Jun 19, 2023

Add rough rudimentary CONTRIBUTING.md

Please if you have any suggestions comment here

CONTRIBUTING.md Outdated Show resolved Hide resolved
@ZJouba
Copy link
Contributor

ZJouba commented Jun 19, 2023

Someone mentioned Jetpack Compose on Matrix, maybe add a little something about that. Also, maybe a link to preferred Kotlin coding standards?

Co-authored-by: Zack <42601911+ZJouba@users.noreply.github.com>
@MV-GH
Copy link
Collaborator Author

MV-GH commented Jun 19, 2023

Someone mentioned Jetpack Compose on Matrix, maybe add a little something about that. Also, maybe a link to preferred Kotlin coding standards?

Jetpack Compose is already mentioned in the README not sure what else to say about it

and I cant find the kotlin coding standards
https://github.com/jeremymailen/kotlinter-gradle their github pages is down for me

@ZJouba
Copy link
Contributor

ZJouba commented Jun 19, 2023

Could link to the ktlint rules https://pinterest.github.io/ktlint/0.49.1/rules/code-styles/?

@MV-GH
Copy link
Collaborator Author

MV-GH commented Jun 19, 2023

Thx for finding that for me, I link to https://pinterest.github.io/ktlint/0.49.1/rules/standard/ instead since we just use the default rules.

@ZJouba
Copy link
Contributor

ZJouba commented Jun 19, 2023

Oh, maybe something about branch name standard as well?

@MV-GH
Copy link
Collaborator Author

MV-GH commented Jun 19, 2023

There is a standard for branch names?

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, content all looks great. This doc will evolve over time anyway.

Just get rid of those hard line-wraps and I'll merge.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@dessalines
Copy link
Member

Haha no standard for branch names or commit content, I'm not a stickler for that stuff. The code is what matters.

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thx!

@dessalines dessalines merged commit a51d83f into LemmyNet:main Jun 19, 2023
@MV-GH MV-GH deleted the doc/contrib branch July 5, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants