Changes to language tag #1036
Changes to language tag #1036
Conversation
- Dont use bright white color because its not that important - Hide tag in case of undetermined (doesnt add any information)
| )?.name | ||
| } | ||
| </span> | ||
| {cv.comment.language_id != 0 && ( |
There was a problem hiding this comment.
Nitpick: !== instead of !=.
| )?.name | ||
| } | ||
| </span> | ||
| {post_view.post.language_id != 0 && ( |
There was a problem hiding this comment.
Same as other comment.
|
Regarding the css class badges: you can get a badge of a given color with "badge badge-(color name here)". The color name would be something from the theme, like light, dark, info, primary etc. Text gets colored similarly with class names like "text-(theme color)". Also, how does this look in lightly? |
|
Good suggestion,
|
| {i18n.t("mod")} | ||
| </div> | ||
| )} | ||
| {isAdmin_ && ( | ||
| <div className="badge badge-light d-none d-sm-inline mr-2"> | ||
| <div className="badge badge-muted d-none d-sm-inline mr-2"> |
There was a problem hiding this comment.
There is no such thing as badge-muted: https://getbootstrap.com/docs/4.6/components/badge/
badge-light is your best bet for most themes. You might be able to add another muted class to it, like text-muted
There was a problem hiding this comment.
Youre right it actually has no effect. So I removed badge-muted, only leaving badge and it still looks the same as in the screenshots.
| @@ -345,7 +345,7 @@ export class PostListing extends Component<PostListingProps, PostListingState> { | |||
| )} | |||
| </li> | |||
| {post_view.post.language_id !== 0 && ( | |||
| <span className="mx-1 badge badge-muted"> | |||
| <span className="mx-1 badge"> | |||
There was a problem hiding this comment.
You're not supposed to use it without the 2nd badge-x class, as it might look weird on some themes. Did you try badge-secondary ?
There was a problem hiding this comment.
Secondary will be orange on lightly I think. It'll bring us back to the badge being too prominent.
There was a problem hiding this comment.
If it looks good on both the litely and darkly, I have no problems merging. Might give issues on other themes tho.
Before:
After:
Not sure about the specific css classes, we can also change it as long as it's gray like the other text and not bright white.