Open links in a new tab setting in UI #1546
Conversation
sbordeyne
requested review from
dessalines,
SleeplessOne1917,
alectrocute and
jsit
as code owners
…geek/lemmy-ui into lemmy-282/add-open-in-new-tab-setting
Head branch was pushed to by a user without write access
| .open_links_in_new_tab | ||
| ) { | ||
| return "_blank"; | ||
| } |
There was a problem hiding this comment.
the else clause here is strictly unnecessary, it's just clutter. At the end of the day, it's the same code, just harder to read. I can add it if you feel like it's strictly necessary, but it doesn't add any value in that instance
There was a problem hiding this comment.
Yes please add it, I don't like default returns.
There was a problem hiding this comment.
So they never added this simple change, and then closed the PR?
…d-open-in-new-tab-setting
|
Closing cause it's never gonna be merged anyways |
|
@SleeplessOne1917 can we get a review on the newest changes, and an idea of whether it's good to go? |
| .open_links_in_new_tab | ||
| ) { | ||
| return "_blank"; | ||
| } |
There was a problem hiding this comment.
So they never added this simple change, and then closed the PR?
Are maintainer commits enabled? If that's the case, can't you address it? It looks like a simple change unrelated to the functionality, that's just because of your preference. |
related to LemmyNet/lemmy#3318