Fix search page to stop couldnt_find_object error
#1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scme0
changed the title
couldnt_find_object error
scme0
commented
Jun 28, 2023
| } | ||
|
|
||
| export class HttpService { | ||
| static #_instance: HttpService; | ||
| #silent_client: WrappedLemmyHttp; |
There was a problem hiding this comment.
Is there a nicer way to achieve this?
scme0
commented
Jun 28, 2023
| if ( | ||
| !(this.state.isIsomorphic || this.props.history.location.state?.searched) | ||
| ) { | ||
| if (!this.state.isIsomorphic) { |
There was a problem hiding this comment.
I changed this because it was causing no search results to display.
scme0
force-pushed
the
scme/add-silent_client
branch
from
f28971c
to
f83cdf0
Compare
scme0
requested review from
dessalines,
SleeplessOne1917,
alectrocute and
jsit
as code owners
src/shared/components/search.tsx
Outdated
|
|
||
| // If we return this object with a state of failed, the catch-all-handler will redirect | ||
| // to an error page, so we ignore it by covering up the error with the empty state. | ||
| if (resolveObjectResponse.state == "failed") { |
There was a problem hiding this comment.
Use triple equals instead of double equals.
There was a problem hiding this comment.
Good catch - will fix 👍
SleeplessOne1917
approved these changes
Jun 28, 2023
jsit
reviewed
Jun 29, 2023
| }); | ||
|
|
||
| await this.search(); | ||
| this.props.history.push(`/search${getQueryString(queryParams)}`); |
There was a problem hiding this comment.
Should we create a global siteUrl constant at some point, in case someone installs Lemmy in a subdirectory or something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When searching for anything that isn't a community or user link (starting with a '!' or '@') while logged in, an error appears as a toast on the search page, or if you're loading the search URL directly, it will show an error page.
Toast:
Error page (when loading the search url with the query parameters directly):
This is because we send a request to the server on the
resolve_objectendpoint which returns an errorcouldnt_find_objectif the input is just random text and it doesn't match to any objects.I've updated the front end to make the requests to
resolve_objectsilent. This means that if there is any error, no toast is shown and it is not logged. I think this is acceptable because of the way we are using the endpoint here. we are just interested if it returns any valid results.I'm unsure if there is a better way to implement a "silent client" though, so please let me know if you can think of something a bit more elegant.
Fixes LemmyNet/lemmy#3296