Fix broken user.auth() method on middleware.ts
#1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alectrocute
requested review from
dessalines,
SleeplessOne1917 and
jsit
as code owners
|
|
SleeplessOne1917
approved these changes
Jun 30, 2023
…into fix-cache-auth
alectrocute
commented
Jun 30, 2023
| @@ -111,9 +111,6 @@ const createClientConfig = (env, mode) => { | |||
| new ServiceWorkerPlugin({ | |||
| enableInDevelopment: mode !== "development", // this may seem counterintuitive, but it is correct | |||
| workbox: { | |||
| modifyURLPrefix: { | |||
| "/": `/static/${env.COMMIT_HASH}/`, | |||
| }, | |||
There was a problem hiding this comment.
This fixes a bad path with our service worker on production.
alectrocute
commented
Jun 30, 2023
| const user = UserService.Instance; | ||
| if (process.env.NODE_ENV !== "production") { | ||
| return next(); | ||
| } |
There was a problem hiding this comment.
Let's not cache anything on dev.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New strategy for this. Let's parse
req.headers.cookiedirectly with a server helper utility.Once #1713, we should updateis-request-authenticatedto usecookie.parse(...).jwt.