Only conditionally render most of content action dropdown and workaround for tippy warning #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tippy doesn't remove its onDocumentPress listener when destroyed. Instead the listener removes itself after calling hide for hideOnClick. It doesn't look like there is a way to reliable work around this. This skips the warning for the first hide call on a destroyed tippy instance. Cleanup is only performed after at least ten tippy instances have been created.
Modals use `await import("bootstrap/js/dist/modal")` when being mounted.
This means its possible that the component unmounts before the promise
resolves.
| @@ -174,292 +188,305 @@ export default class ContentActionDropdown extends Component< | |||
| aria-expanded="false" | |||
| aria-controls={dropdownId} | |||
| aria-label={I18NextService.i18n.t("more")} | |||
| onClick={() => this.setState({ dropdownOpenedOnce: true })} | |||
There was a problem hiding this comment.
Should use linkEvent with this. This will also involve creating a function that takes the ContentActionDropdown as an arg and calls setState on it.
|
I noticed that the dynamic import and setup/cleanup gets repeated everywhere we use the modal. Do you think mixins similar to what you did in the previous PR could alleviate this? |
SleeplessOne1917
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only starts rendering the dropdown and each modal dialog when they are shown for first time. For simplicity they keep getting rendered until the component unmounts.
A small fix when the Modal promise resolves after the component umounts. I don't remember how to trigger this, but saw this occasionally happen.
Also a work around for the tippy warning. Turns out tippy doesn't remove all event listeners when it destroys an instance.