Add fallback image for broken images #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
reviewed
Apr 22, 2024
|
|
||
| function handleImgLoadError(i: PictrsImage) { | ||
| i.setState({ | ||
| src: `${getStaticDir()}/assets/images/broken-image-fallback.png`, |
There was a problem hiding this comment.
Try this solution to see if it works.
<img src="foo.jpg" onerror="this.src='NEW_SRC_LOC>
Then we could avoid having to have to create a src state variable, and hooks, just to handle the error case.
There was a problem hiding this comment.
<img src="foo.jpg" onerror="this.src='NEW_SRC_LOC>
I tried something similar at some point. Worked fine in dev. But in prod the CSP complained about inline-scripts.
There was a problem hiding this comment.
Ah, in that case this is good then.
dessalines
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2433.
This is what is looks like with the fallback image:
