Keep CreatePost mounted when updating URL, fixes focus resets. #2520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SleeplessOne1917
approved these changes
Jun 7, 2024
| @@ -121,6 +121,7 @@ export const routes: IRoutePropsWithFetch<RouteData, any, any>[] = [ | |||
| component: CreatePost, | |||
| fetchInitialData: CreatePost.fetchInitialData, | |||
| getQueryParams: getCreatePostQueryParams, | |||
| mountedSameRouteNavKey: "create_post", | |||
There was a problem hiding this comment.
In App routes without that property get the location.key assigned as key, so that they unmount whenever the location changes. Before that property all routes behaved like that.
| @@ -237,6 +249,7 @@ export class CreatePost extends Component< | |||
| <div id="createPostForm" className="col-12 col-lg-6 offset-lg-3 mb-4"> | |||
| <h1 className="h4 mb-4">{I18NextService.i18n.t("create_post")}</h1> | |||
| <PostForm | |||
| key={this.state.resetCounter} | |||
There was a problem hiding this comment.
Using a key (outside of a collection) to prevent uneccessary rerenders. Clever.
There was a problem hiding this comment.
It still has to render even when the key stays the same. But the when the key changes it has to be recreated and resets its state. I added it so that the "Create Post" link in the top navigation completely resets the form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking on another input element now moves the focus. Without this change the clicked input element is replaced with a new one during URL update.