Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't swallow errors in API code #1834

Closed
Nutomic opened this issue Oct 12, 2021 · 0 comments
Closed

Don't swallow errors in API code #1834

Nutomic opened this issue Oct 12, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@Nutomic
Copy link
Member

Nutomic commented Oct 12, 2021

I am currently trying to help the admin of forum.nogafam.es to debug a problem on the instance. The problem is that fetching remote communities or other objects doesnt work, and it only returns "error: couldnt_find_object". The actual error message from search_by_apub_id() is silently dropped, but it should be logged at the very least.

https://github.com/LemmyNet/lemmy/blob/main/crates/api/src/site.rs#L390

This same pattern is used all over the API code, and should be fixed everywhere.

@Nutomic Nutomic added the enhancement New feature or request label Oct 12, 2021
Nutomic added a commit that referenced this issue Oct 13, 2021
dessalines pushed a commit that referenced this issue Oct 13, 2021
Dont swallow API errors (fixes #1834)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant