Make remove content optional during account deletion (fixes #1617) #3817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
commented
Aug 4, 2023
| .await?; | ||
| } else { | ||
| Person::delete_account(&mut context.pool(), local_user_view.person.id).await?; | ||
| } |
There was a problem hiding this comment.
This was called from the federation code for some reason.
Nutomic
force-pushed
the
delete-account-data
branch
from
bdeab73
to
216f309
Compare
|
Mmmk, I'll start an RC for that. |
dessalines
approved these changes
Aug 8, 2023
|
Okay the new lemmy-js-client is started at |
|
Updated. Locally Im still getting the same test failure, lets see if it works in ci. |
This was referenced Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be possible to delete a user account without wiping all posts and comments. This can also reduce server load.
Requires a new lemmy-js-client version for api tests.