Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Replace ad hoc auth header with internet standard bearer token auth header #3982

Merged
merged 8 commits into from
Sep 26, 2023
Merged

feat: Replace ad hoc auth header with internet standard bearer token auth header #3982

merged 8 commits into from
Sep 26, 2023

Conversation

SleeplessOne1917
Copy link
Member

@SleeplessOne1917 SleeplessOne1917 commented Sep 23, 2023 •
edited
Loading

Does as the title says

The only file that was changed that wasn't a Cargo.toml/lock file was the session middleware. All the other changes were from running cargo fmt to try to satisfy the woodpecker build to no avail.

@SleeplessOne1917 SleeplessOne1917 mentioned this pull request Sep 23, 2023
Merged
Nutomic
Nutomic reviewed Sep 25, 2023
View reviewed changes
crates/api_crud/Cargo.toml Outdated Show resolved Hide resolved
@Nutomic
Copy link
Member

Nutomic commented Sep 25, 2023

I already implemented this in #3818, but your change is much cleaner so lets use that.

To make the API tests pass you have to set the correct header there, analogous to this change from my PR: b2bacd1

dessalines
dessalines approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thx.

@SleeplessOne1917 SleeplessOne1917 merged commit 9a9ece8 into LemmyNet:main Sep 26, 2023
@mormaer mormaer mentioned this pull request Sep 30, 2023
Closed
@NatoBoram NatoBoram mentioned this pull request Dec 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nutomic Nutomic Nutomic left review comments

@dessalines dessalines dessalines approved these changes

@phiresky phiresky Awaiting requested review from phiresky phiresky is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SleeplessOne1917 @Nutomic @dessalines