More frequent rate limiter cleanup #4240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dullbananas
requested review from
Nutomic,
dessalines and
phiresky
as code owners
|
I think its unlikely that this will help. According to @dessalines lemmy.ml crashes once a day, so the cleanup job already runs 24 times during that duration. The only way this could cause OOM would be if there are lots of requests from different IPs within one hour which seems unlikely. That said, lots of requests from different IPs is the pattern of a DDoS, so a more frequent cleanup makes sense to avoid any vulnerability there. |
Nutomic
approved these changes
Dec 11, 2023
dessalines
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might fix #3183