Fixing extra modlog entries when post_id or comment_id is given. #4664
Conversation
dessalines
commented
Apr 24, 2024
dessalines
commented
- Previously when given a post_id, it didn't filter out any other modlog entries, such as community removals. This fixes that problem.
- Context: Mod action history lemmy-ui#2437
- Previously when given a post_id, it didn't filter out any other modlog entries, such as community removals. This fixes that problem. - Context: LemmyNet/lemmy-ui#2437
dessalines
requested review from
Nutomic,
phiresky,
dullbananas and
SleeplessOne1917
as code owners
| @@ -40,6 +40,11 @@ impl AdminPurgeCommentView { | |||
| query = query.filter(admin_purge_comment::admin_person_id.eq(admin_person_id)); | |||
| }; | |||
|
|
|||
| // If a post or comment ID is given, then don't find any results | |||
| if params.post_id.is_some() || params.comment_id.is_some() { | |||
There was a problem hiding this comment.
I could've externalized this, but since the two other cases (only checking for one of them) also exist, it doesn't seem worth it.
There was a problem hiding this comment.
Its good enough, I hope we can do a cleaner solution for this together with #2444
| @@ -58,6 +58,11 @@ impl ModRemoveCommentView { | |||
| query = query.filter(comment::id.eq(comment_id)); | |||
| } | |||
|
|
|||
| // If a post ID is given, then don't find any results | |||
| if params.post_id.is_some() { | |||
There was a problem hiding this comment.
This one's the only weird case. We could show comment removals (since this has to join to the post table anyway, and filter by post_id) .
I tried it out in the front end, and although it works, it seems like if you provide a post id, you only want to see mod actions done on the post, not comments within the post.
I could be persuaded otherwise tho, as it might be useful to see actions taken on comments when filtering by a post id.
There was a problem hiding this comment.
I think the approach you already made is fine.
There was a problem hiding this comment.
There was a problem hiding this comment.
Both options should be possible, so there should be a "show_children" option that includes comments when given post_id, child comments when given comment_id, and maybe posts and comments when given community_id
There was a problem hiding this comment.
Not a bad idea. Could you open an issue for that one? Lets leave that for a later time.
