Dont federate post locking via Update activity #4717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
requested review from
dessalines,
phiresky,
dullbananas and
SleeplessOne1917
as code owners
dullbananas
reviewed
May 14, 2024
| }; | ||
| ModLockPost::create(&mut context.pool(), &form).await?; | ||
| } | ||
|
|
There was a problem hiding this comment.
This might need to be kept.
There was a problem hiding this comment.
Its not necessary here anymore as posts cant be locked this way. Instead it uses the lock page activity. But I just noticed that it didnt write the mod log at all, so Ive added that now.
dessalines
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This receiving logic has actually not been used for a while now so we can safely remove it. It also has some rather messy logic that could result in security problems so better to get rid of it soon.