Dont show replies / mentions from blocked users. Fixes #4227 #4727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
requested review from
Nutomic,
phiresky,
dullbananas and
SleeplessOne1917
as code owners
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
Tests should be added |
|
Gotcha, I'll add tests shortly. |
- Also cleaned up some unwraps in the tests.
dessalines
commented
May 21, 2024
| @@ -87,117 +87,3 @@ impl CommentReply { | |||
| .optional() | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I moved these tests into the views, since they'd be redundant anyway.
dessalines
commented
May 21, 2024
| let inserted_instance = Instance::read_or_create(pool, "my_domain.tld".to_string()) | ||
| .await | ||
| .unwrap(); | ||
| async fn init_data(pool: &mut DbPool<'_>) -> LemmyResult<Data> { |
There was a problem hiding this comment.
No logical changes in this file, other than to remove some unecessary unwraps.
dessalines
commented
May 21, 2024
Cargo.lock
Outdated
There was a problem hiding this comment.
I needed to do cargo update to get rust nightly working again.
SleeplessOne1917
approved these changes
May 21, 2024
Nutomic
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.