Unit tests and cleanup for outgoing federation code #4733
Conversation
| tracing::warn!("task exited, restarting: {res:?}"); | ||
| } | ||
| } | ||
| }); |
There was a problem hiding this comment.
This loop here seems completely unnecessary as the send worker is already looping on its own.
There was a problem hiding this comment.
If the instance worker loop actually reliably looped it would have a return type of ! or (), but it returns a result. the reason this restart is necessary is that on internal errors, the function exits and the worker needs to be restarted
| @@ -94,11 +94,15 @@ impl Instance { | |||
| .await | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
| /// Only for use in tests | |||
| pub async fn delete_all(pool: &mut DbPool<'_>) -> Result<usize, Error> { | |||
There was a problem hiding this comment.
Had to remove this because items marked as #[cfg(test)] are only available within the same crate.
| } | ||
| } | ||
| info!("{ok_count} others up to date. {behind_count} instances behind."); | ||
| } |
There was a problem hiding this comment.
Moved this stuff into separate file without changes.
Nutomic
changed the title
Nutomic
requested review from
dessalines,
phiresky,
dullbananas and
SleeplessOne1917
as code owners
There was a problem hiding this comment.
Not my area of expertise, so it might be good for @phiresky to take a look.
| for (instance_id, stat) in stats { | ||
| let domain = &instances | ||
| .iter() | ||
| .find(|i| &i.id == instance_id) |
There was a problem hiding this comment.
this is a pretty unnecessary O(n^2) that was added, this looped through ~5k things before, now it loops through 25 million things every time.
No description provided.