Skip to content

Commit

Permalink
Update for next release
Browse files Browse the repository at this point in the history
  • Loading branch information
Leonidas-from-XIV committed Aug 14, 2017
1 parent 434abf4 commit 51ce146
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion lib/bom.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/builder.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/defaults.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/parser.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/processors.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/xml2js.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"json"
],
"homepage": "https://github.com/Leonidas-from-XIV/node-xml2js",
"version": "0.4.17",
"version": "0.4.18",
"author": "Marek Kubica <marek@xivilization.net> (https://xivilization.net)",
"contributors": [
"maqr <maqr.lollerskates@gmail.com> (https://github.com/maqr)",
Expand Down

6 comments on commit 51ce146

@browndp08
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Leonidas-from-XIV with b9b44e0, this really should be a major version bump.

@Leonidas-from-XIV
Copy link
Owner Author

@Leonidas-from-XIV Leonidas-from-XIV commented on 51ce146 Aug 14, 2017 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbechet
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Leonidas-from-XIV. I agree with @browndp08.

@browndp08
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Leonidas-from-XIV technically, sure below 1.0 does not specify behavior, but practically, with 7 million downloads in the last month, should this library still be versioned below 1.0? Maybe you're handling the invalid XML better, but you're also throwing an error when you did not before, so that's most definitely a breaking change. Literally, code broke 😄. This package has been very successful, so congrats on that! That said, you may not have a technical responsibility to make this 1.0.0 or to limit breaking changes from appearing in patch versions, but you may want to consider the practical impacts on your real users.

@Leonidas-from-XIV
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@browndp08 If you check out the huge list of options required to get reasonable behaviour out of the library (because changing it would break code) and the fact that the parseString takes callbacks, you can't really blame me for breaking compatibility very often.

What I would agree with is the fact that the behaviour of faulty XML being fed into this library is very bad and essentially often random, so instead of one random behaviour you get something hopefully a bit less random.

@Leonidas-from-XIV
Copy link
Owner Author

@Leonidas-from-XIV Leonidas-from-XIV commented on 51ce146 Aug 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've released 0.4.19 without that commit.

But please make sure your code does not depend on invalid XML being parsed.

Please sign in to comment.