Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated API? #43

Open
pm5 opened this issue May 31, 2023 · 3 comments
Open

Outdated API? #43

pm5 opened this issue May 31, 2023 · 3 comments

Comments

@pm5
Copy link
Contributor

pm5 commented May 31, 2023

With the included slack_notify CLI tool one can find a few outdated usage of Slack Web API:

  • Authentication can no longer be done with a token=... argument, but must be with Authorization header.
  • channels.list method seems to be replaced by admin.usergroups.listChannels.

There also seems to be a lot of methods not supported, such admins.*, reactions.*, reminders.*, usergroups.* (replaces groups.* probably), etc.
@Leonidas-from-XIV
Copy link
Owner

Yes, indeed, I haven't kept up with the API changes in the last couple of years. It would need some updating to get back to an usable state, but I haven't had the time to do so, given I don't automate Slack much these days anymore.

Pull requests are of course welcome, I'll try to review them quickly.

@pm5
Copy link
Contributor Author

pm5 commented Jun 1, 2023

I might be able to help since I'm doing a side project that will use Slack API.

@Leonidas-from-XIV
Copy link
Owner

Sounds good! I've merged your PRs and modernized the library a bit so it is a better place to start.

@pm5 pm5 mentioned this issue Jun 2, 2023
Merged
pm5 added a commit to pm5/slacko that referenced this issue Jun 6, 2023
@pm5
fix: slack-notify cli
f4b80c4 
- This partially addresses Leonidas-from-XIV#43
- `channels.list` seems to become `conversations.list` now.
- Responses of `conversations.list` are limited conversation objects
  that do not have `members` attribute.
- No need to trime channel names anymore?
@pm5 pm5 mentioned this issue Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pm5 @Leonidas-from-XIV