override _setupIteratorOptions, without clobbering ranges

[dominictarr]

follows the patterns in #44 except it preserves ranges.

I'm a little wary of doing it this way, because _setupIteratorOptions is not an official public api of leveldown (not mentioned in the documentation). I've already been bitten by depending on obsecure edgecases in level, that have been removing in the course of routine maintainence. I would be more confidant about the stability of https://github.com/Level/encoding-down/pull/43/files because I know iterator isn't going anywere. But I can easily imagine someone forgetting about _setupIteratorOptions, refactoring it, and this then stops working.

[ralphtheninja]

I'm a little wary of doing it this way, because _setupIteratorOptions is not an official public api of leveldown (not mentioned in the documentation)

We can make it part of the official public api.

I've already been bitten by depending on obsecure edgecases in level, that have been removing in the course of routine maintainence.

That's not good. What are the other types of problems you have been running in to?

I would be more confidant about the stability of https://github.com/Level/encoding-down/pull/43/files because I know iterator isn't going anywere.

Assuming it's part of the official api, this isn't that much different from implementing ._put(). There's also deferral of methods in deferred-leveldown that builds on this, which would break if overriding .iterator() (see https://github.com/Level/deferred-leveldown/blob/master/deferred-leveldown.js#L46-L50).

But I can easily imagine someone forgetting about _setupIteratorOptions, refactoring it, and this then stops working.

We write tests for this.

[dominictarr]

sure if you want to make _setupIteratorOptions part of the official api, then i'm 👍 👍

[ralphtheninja]

LGTM

[ralphtheninja]

@dominictarr How urgent is this? We can throw out a patch immediately if you like and fix the tests + docs later.

[vweevers]

This mutates the options. @dominictarr can you throw in a options = xtend(options)? With xtend.

Re: stability of _setupIteratorOptions: IMO this is a temporary solution anyway. It's not gonna cut it if you do db.createReadStream({ gt: null }) before the db has opened, or if you wrap the db with other stuff.

Down the line it should be solved in abstract-leveldown, possibly by reverting the null check and preparing implementations for that.

[dominictarr]

@vweevers fixed to use xtend

[dominictarr]

@ralphtheninja a patch soon would be helpful

[vweevers]

fixed to use xtend

I don't see it. Did you push?

[ralphtheninja]

4.0.1

[ralphtheninja]

and in 5.0.1

[dominictarr]

@ralphtheninja thanks! need a patch to level though, 3.0.1 still has leveldown@3, but master is leveldown@4

[vweevers]

@dominictarr we'll get that out asap, we're also squeezing in other updates.

[ralphtheninja]

@dominictarr Hmm I don't understand. Installing level gives you encoding-down@4.0.1 or do you need something else than that?

[dominictarr]

@ralphtheninja sorry you are right! I see there is a patch version of level-packager!

[ralphtheninja]

@ralphtheninja sorry you are right! I see there is a patch version of level-packager!

Cool. Let us know if there's anything else that's borked!