-
-
Notifications
You must be signed in to change notification settings - Fork 66
Add challenge around "git push" #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Closes LibraryCarpentry#166. This lesson has few challenges, so this issue seemed like a good opportunity to add one.
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-git/compare/md-outputs..md-outputs-PR-182 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2025-08-14 08:21:03 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm offering slightly more in-depth language for the solution:
Branches can be configured with an "upstream" branch (a branch on a remote
repository), which is used automatically for `push` and `pull` operations. The
`main` branch's upstream wasn't set when we created it. The `-u` (or
`--set-upstream`) flag tells `git push` which remote branch to use; it also sets
the remote branch as the local branch's upstream. Once we've set it, we don't
need to specify the remote branch in future `push` and `pull` operations.
Feel free to incorporate it, or not. Otherwise this, looks good!
Incorporates wording from @srerickson. Thank you!
Thank you for the more thorough explanation, which I've incorporated. I think this reinforces the point that we need to find somewhere to explain what a branch is, as touched on in #54. |
Auto-generated via `{sandpaper}` Source : a27842a Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2025-08-14 08:32:50 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : 16a41d4 Branch : main Author : Alex Ball <alex-ball@users.noreply.github.com> Time : 2025-08-14 08:32:08 +0000 Message : Merge pull request #182 from alex-ball/patch-166 Add challenge around "git push"
Auto-generated via `{sandpaper}` Source : a27842a Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2025-08-14 08:32:50 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : 16a41d4 Branch : main Author : Alex Ball <alex-ball@users.noreply.github.com> Time : 2025-08-14 08:32:08 +0000 Message : Merge pull request #182 from alex-ball/patch-166 Add challenge around "git push"
Auto-generated via `{sandpaper}` Source : a27842a Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2025-08-14 08:32:50 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : 16a41d4 Branch : main Author : Alex Ball <alex-ball@users.noreply.github.com> Time : 2025-08-14 08:32:08 +0000 Message : Merge pull request #182 from alex-ball/patch-166 Add challenge around "git push"
Auto-generated via `{sandpaper}` Source : a27842a Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2025-08-14 08:32:50 +0000 Message : markdown source builds Auto-generated via `{sandpaper}` Source : 16a41d4 Branch : main Author : Alex Ball <alex-ball@users.noreply.github.com> Time : 2025-08-14 08:32:08 +0000 Message : Merge pull request #182 from alex-ball/patch-166 Add challenge around "git push"
In episode three, we explain that our first, longer use of
git push
allows us to use a shorter form later, but we don't call back to that explanation when it happens. There are several ways we could do so, but I think using a challenge would be good as the lesson doesn't have very many of them.Closes #166.