jre.zulu: initial addon #3653

vpeter4 · 2019-07-05T13:45:13Z

Java Runtime Environment 8 for Blu-ray Disc Java menus from Azul Systems.
Also includes libbluray-j2se-*.jar file. Maybe would be better to include this file as part of the image and use only JRE as addon?

packages/addons/addon-depends/jre-depends/jre-libXinerama/package.mk

packages/addons/addon-depends/jre-depends/jre-libbluray/package.mk

MilhouseVH · 2019-07-05T14:24:34Z

No aarch64 support?

I doubt anything JRE-related will be added to images any time soon - best to keep this entirely as an addon for those that want it.

packages/addons/addon-depends/jre-depends/jre-libbluray/package.mk

vpeter4 · 2019-07-05T14:43:42Z

Will add aarch64.
I understand that JRE related things doesn't belong in small image (JRE itself is ~40MB). The question was more to include only libbluray-j2se-*.jar which is ~800kB.
Now the problem can happen with addon update when libbluray version is bumped. In this case addon will be bumped too and systems with old Kodi version will be upgraded to newer libbluray jar. Not sure if this can work. But for now users can just downgrade in this case. We can always change that in future updates.

vpeter4 · 2019-07-05T15:02:12Z

@chewitt: Can you make one nice icon please?

chewitt · 2019-07-05T17:38:18Z

packages/addons/addon-depends/jre-depends/jre-libbluray/patches/dummy

MilhouseVH · 2019-07-06T09:52:24Z

@vpeter On a point of etiquette, would you mind changing your copyright attribution to include your real name and email address (the same as it is in your git commits)? This would then be consistent with pretty much all other attributions in the code base. Thanks!

CvH

just nits

CvH · 2019-07-06T15:40:00Z

packages/addons/addon-depends/jre-depends/jdk-aarch64-zulu/package.mk

+PKG_LICENSE="GPLv2"
+PKG_SITE="https://www.azul.com/products/zulu-embedded/"
+PKG_URL="http://cdn.azul.com/zulu-embedded/bin/zulu8.38.0.162-ca-jdk1.8.0_212-linux_aarch64.tar.gz"
+PKG_DEPENDS_TARGET=""


Suggested change

PKG_DEPENDS_TARGET=""

CvH · 2019-07-06T15:40:11Z

packages/addons/addon-depends/jre-depends/jdk-arm-zulu/package.mk

+PKG_LICENSE="GPLv2"
+PKG_SITE="https://www.azul.com/products/zulu-embedded/"
+PKG_URL="https://cdn.azul.com/zulu-embedded/bin/zulu8.38.0.163-ca-jdk1.8.0_212-linux_aarch32hf.tar.gz"
+PKG_DEPENDS_TARGET=""


Suggested change

PKG_DEPENDS_TARGET=""

CvH · 2019-07-06T15:40:19Z

packages/addons/addon-depends/jre-depends/jdk-x86_64-zulu/package.mk

+PKG_LICENSE="GPLv2"
+PKG_SITE="https://www.azul.com/products/zulu-enterprise/"
+PKG_URL="https://cdn.azul.com/zulu/bin/zulu8.38.0.13-ca-jdk8.0.212-linux_x64.tar.gz"
+PKG_DEPENDS_TARGET=""


Suggested change

PKG_DEPENDS_TARGET=""

CvH · 2019-07-06T15:41:03Z

packages/addons/addon-depends/jre-depends/jdk-x86_64-zulu/package.mk

+# Copyright (C) 2019-present Peter Vicman (peter.vicman@gmail.com)
+
+PKG_NAME="jdk-x86_64-zulu"
+PKG_VERSION="8u212"


PKG_VERSION not used at URL ? I see there is some meh versioning going on but maybe use at least 8.38.0.13 ?

8u212 is OpenJDK version which this zulu binary is based on. But will change to zulu binary version like 8.38.0.13 in this case.

CvH · 2019-07-06T15:44:29Z

packages/addons/tools/jre.zulu/package.mk

+PKG_DEPENDS_TARGET="jdk-${TARGET_ARCH}-zulu jre-libbluray libXext chrome-libXtst chrome-libXi chrome-libXrender jre-libXinerama"
+PKG_SHORTDESC="Java Runtime Environment 8 for Blu-ray Disc Java menus from Azul Systems."
+PKG_LONGDESC="$PKG_SHORTDESC"
+PKG_TOOLCHAIN="manual"


Suggested change

PKG_TOOLCHAIN="manual"

PKG_TOOLCHAIN="manual"

CvH · 2019-07-06T15:47:34Z

packages/addons/tools/jre.zulu/source/default.py

@@ -0,0 +1,2 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+# Copyright (C) 2016-present Team LibreELEC (https://libreelec.tv)


Suggested change

# Copyright (C) 2016-present Team LibreELEC (https://libreelec.tv)

# Copyright (C) 2019-present Team LibreELEC (https://libreelec.tv)

CvH · 2019-07-06T15:48:01Z

packages/addons/tools/jre.zulu/source/default.py

@@ -0,0 +1,2 @@
+# SPDX-License-Identifier: GPL-2.0-or-later


Suggested change

# SPDX-License-Identifier: GPL-2.0-or-later

# SPDX-License-Identifier: GPL-2.0

to align with all other default.py files we have, because there is no copy worthy content here so just a placeholder? also this is addon is introduced 2019 so i guess 2019-present ?

CvH · 2019-07-06T15:51:42Z

packages/addons/tools/jre.zulu/changelog.txt

@@ -0,0 +1,2 @@
+101
+- Initial release


Suggested change

- Initial release

- Initial release

100

- private test version

CvH · 2019-07-06T15:52:37Z

packages/addons/addon-depends/jre-depends/jre-libXinerama/package.mk

@@ -0,0 +1,20 @@
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (C) 2018-present Team LibreELEC (https://libreelec.tv)


Suggested change

# Copyright (C) 2018-present Team LibreELEC (https://libreelec.tv)

# Copyright (C) 2019-present Team LibreELEC (https://libreelec.tv)

CvH · 2019-07-06T15:52:50Z

packages/addons/addon-depends/jre-depends/jre-libbluray/package.mk

@@ -0,0 +1,35 @@
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (C) 2018-present Team LibreELEC (https://libreelec.tv)


Suggested change

# Copyright (C) 2018-present Team LibreELEC (https://libreelec.tv)

# Copyright (C) 2019-present Team LibreELEC (https://libreelec.tv)

vpeter4 · 2019-07-06T20:01:36Z

Still builds fine for Generic, RPi2 and Rockchip. Runs on Generic.

MilhouseVH · 2019-07-07T00:59:10Z

I'm not able to build jre-libbluray for Generic/x86_64 on Ubuntu 16.04 because ant isn't found during jre-libbluray configure.

Log: http://ix.io/1NTv

This build includes the latest #3655 and #3661.

Command line:

git clone https://github.com/LibreELEC/LibreELEC.tv.git LibreELEC.tv-test
cd LibreELEC.tv-test
git checkout -b vpeter
wget -q https://github.com/LibreELEC/LibreELEC.tv/pull/3655.patch -O- | git am
wget -q https://github.com/LibreELEC/LibreELEC.tv/pull/3661.patch -O- | git am
wget -q https://github.com/LibreELEC/LibreELEC.tv/pull/3653.patch -O- | git am
PROJECT=Generic ARCH=x86_64 scripts/create_addon jre.zulu

History: http://ix.io/1NTx, Plan: http://ix.io/1NTy

apache-ant has been built successfully, but you're not appending $(get_build_dir apache-ant)/binary/bin to $PATH during the configure_target() phase, so the package configure doesn't find a usable ant - I don't have any version of ant installed on this build host but you presumably do which may explain why this doesn't fail for you.

I would suggest installing ant into $TOOLCHAIN/bin (and associated Java classes into something like $TOOLCHAIN/java or similar - your choice, whatever is "standard" for Java these days) and this then avoids fiddling with $PATH both during configure_target and everywhere else.

At the very least if you copied binary/bin/ant into $TOOLCHAIN/bin it's enough to keep configure happy and then this PR builds (using this patch: http://ix.io/1NTA) but that's just a temporary hack solution so I'd rather we installed a working version of ant into $TOOLCHAIN and removed the $PATH modifications. Thanks!

MilhouseVH · 2019-07-07T01:25:20Z

This patch applies on top of this PR and installs ant to $TOOLCHAIN allowing this PR to build successfully on systems without ant, and without modifying $PATH.

This add-on now builds (for Generic) but not run-time tested. Will try building for RPi2/arm.

packages/addons/tools/jre.zulu/package.mk

MilhouseVH · 2019-07-07T03:53:52Z

No issues building Generic, RPi2 and RPi with ant patch, although there's probably very little point building this add-on for DEVICE=RPi (RPi0, RPi1 etc.) as I doubt anyone will be mad enough to install it.

I'm not able to run-time test these add-ons, but I have uploaded them here (for LE master/Kodi 18.3):

http://milhouse.libreelec.tv/other/jbd-addons

vpeter4 · 2019-07-07T06:42:43Z

Ah, I missed configure phase. And I was checking to not miss something.
Fixes applied.

And regarding running this on RPi1: I know one guy who did. He doesn't have any disk to test but BD-J games indeed work so menu was showed.

Your Generic addon works. Also RPi2 on Wetek Play. No arm64 device here.

To test you can try playing game Ukko's Journey (Blu-Play version) from http://www.pouet.net/prod.php?which=68910

MilhouseVH · 2019-07-07T07:18:35Z

Squash them down, and stick a fork in it? 😄

This PR is now dependent on #3661 but I'd hope that merges soon (next few days).

MilhouseVH · 2019-07-08T05:37:42Z

@vpeter just an FYI - I tried a test build (image) that includes #3667, and built this addon (also with #3667), and it no longer works with the test video.

This is the debug log when using libbluray-1.1.2 and opening the Blu-ray menu from the test disk: http://ix.io/1NZI

Not really sure if it's the ISO that is the problem - it's my only test disk.

I don't know when we will merge libbluray-1.1.2, I suspect we may wait for Team Kodi to make the first move which I suspect will happen during Kodi 19, but thought you might want to know there may be an issue with this add-on.

MilhouseVH · 2019-07-08T05:40:36Z

When I say it no longer works, what I mean is you see a Kai Toast appear with the message
"
Playback of Blu-ray failed
The menu of this blu-ray is not supported
"

vpeter4 · 2019-07-08T06:16:08Z

I assume it is because of this?

CBlurayCallback::Logger - bdj.c:583: Cant access AWT jar file /storage/.kodi/addons/tools.jre.zulu/libbluray-awt-j2se-1.1.2.jar

It is companion file to libbluray-j2se-1.1.2.jar. Introduced in 1.1.0.

Java Runtime Environment 8 for Blu-ray Disc Java menus from Azul Systems. Also includes libbluray-j2se-*.jar file.

MilhouseVH · 2019-07-08T07:01:12Z

I just deleted all my libbluray-1.1.2 based build directories, but if you have a patch I can rebuild the RPi2 image and this add-on with libbluray-1.1.2 and try again?

vpeter4 · 2019-07-08T07:02:38Z

It was pushed 32 minutes ago :-)

vpeter4 · 2019-07-08T08:29:53Z

Working fine with libbluray-1.1.2 too.

MilhouseVH · 2019-07-08T09:32:03Z

Thanks, seems to be working fine now with 1.1.2 on RPi2.

However, I did experience a crash with my libbluray-1.1.2 build: http://ix.io/1O0z - I had been watching a BDISO video started from the BD-J menu, and then it crashed several minutes after the video started (it had been fine up until the crash). I'll see if I can reproduce with libbluray-1.0.2.

Edit:

I found this entry in the system log:

Jul 08 10:20:34 rpi22 kodi.sh[701]: #
Jul 08 10:20:34 rpi22 kodi.sh[701]: # A fatal error has been detected by the Java Runtime Environment:
Jul 08 10:20:34 rpi22 kodi.sh[701]: #
Jul 08 10:20:34 rpi22 kodi.sh[701]: #  SIGSEGV (0xb) at pc=0x007fd4cc, pid=705, tid=0x3c9b0380
Jul 08 10:20:34 rpi22 kodi.sh[701]: #
Jul 08 10:20:34 rpi22 kodi.sh[701]: # JRE version: OpenJDK Runtime Environment (8.0_212-b163) (build 1.8.0_212-b163)
Jul 08 10:20:34 rpi22 kodi.sh[701]: # Java VM: OpenJDK Client VM (25.212-b163 mixed mode, Evaluation linux-aarch32 )
Jul 08 10:20:34 rpi22 kodi.sh[701]: # Problematic frame:
Jul 08 10:20:34 rpi22 kodi.sh[701]: # C  [kodi.bin+0x7f54cc]  CDVDInputStreamBluray::OpenMVCDemux(int)+0x14c
Jul 08 10:20:34 rpi22 kodi.sh[701]: #
Jul 08 10:20:34 rpi22 kodi.sh[701]: # Core dump written. Default location: //core or core.705
Jul 08 10:20:34 rpi22 kodi.sh[701]: #
Jul 08 10:20:34 rpi22 kodi.sh[701]: # An error report file with more information is saved as:
Jul 08 10:20:34 rpi22 kodi.sh[701]: # /tmp/hs_err_pid705.log
Jul 08 10:20:34 rpi22 kodi.sh[701]: #
Jul 08 10:20:34 rpi22 kodi.sh[701]: # If you would like to submit a bug report, please visit:
Jul 08 10:20:34 rpi22 kodi.sh[701]: #   http://www.azulsystems.com/support/
Jul 08 10:20:34 rpi22 kodi.sh[701]: #

/tmp/hs_err_pid705.log -> http://ix.io/1O0C

MilhouseVH · 2019-07-08T10:43:32Z

I had a crash during 3D BD ISO video playback (in monoscopic mode) with libbluray-1.0.2: http://ix.io/1O0L - this seemed to be MVC related so may be a different issue and unrelated to this add-on. So far I haven't reproduced a JVM crash with libbluray-1.0.2, however the JVM crash with libbluray-1.1.2 also occurred during 3D BDISO playback (monoscopic), so maybe it's being triggered by an MVC issue?

vpeter4 · 2019-07-08T10:49:09Z

This crash is for someone else who understand how things work.

The main idea about this addon was to collect some informations about this BD-J area. Maybe in time we can get better user experience. Because there are questions on forum from time to time about this menus.

vpeter4 · 2019-07-08T11:35:39Z

For me playing 8-bit Memoirs Issue #1 English http://www.pouet.net/prod.php?which=72494 causes Kodi to restart without crashlog or any useful info.
Mhm: OOM is the cause?
At some point Kodi starts eating memory. Sadly don't know how to identify the place.

Seems libbluray version doesn't matter.
Same problem also with Oracle JRE.

MilhouseVH · 2019-08-02T14:44:47Z

@vpeter4 do you want to backport this to libreelec-9.2? I think it should backport easily enough. Then we can include it with 9.1.003 etc.

vpeter4 · 2019-08-02T15:33:23Z

Let me look and test over weekend.

vpeter4 · 2019-08-03T06:50:28Z

Seems this PR can be directly used on libreelec-9.2 branch (checked with Generic and RPi2 ). If you want you can send PR (I have limited access for next few days).

MilhouseVH · 2019-08-05T17:30:45Z

Backport added to #3734. Thanks!

vpeter4 · 2019-08-05T18:17:20Z

Thank you!

vpeter4 added ADDONS FEATURE PACKAGE LE 10.0 labels Jul 5, 2019

MilhouseVH reviewed Jul 5, 2019

View reviewed changes

packages/addons/addon-depends/jre-depends/jre-libbluray/package.mk Outdated Show resolved Hide resolved

MilhouseVH reviewed Jul 6, 2019

View reviewed changes

packages/addons/addon-depends/jre-depends/jre-libbluray/patches/dummy Outdated Show resolved Hide resolved

vpeter4 force-pushed the jre.m branch from d4eb25e to 62ec32a Compare July 6, 2019 12:03

CvH reviewed Jul 6, 2019

View reviewed changes

vpeter4 force-pushed the jre.m branch 2 times, most recently from cba5d58 to 503d6ea Compare July 6, 2019 17:17

MilhouseVH reviewed Jul 7, 2019

View reviewed changes

packages/addons/tools/jre.zulu/package.mk Show resolved Hide resolved

vpeter4 force-pushed the jre.m branch from 701bf5b to ad36c99 Compare July 7, 2019 07:20

MilhouseVH mentioned this pull request Jul 8, 2019

libbluray: update to 1.1.2 #3667

Merged

jre.zulu: initial addon

baa626e

Java Runtime Environment 8 for Blu-ray Disc Java menus from Azul Systems. Also includes libbluray-j2se-*.jar file.

vpeter4 force-pushed the jre.m branch from ad36c99 to baa626e Compare July 8, 2019 06:29

CvH approved these changes Aug 2, 2019

View reviewed changes

CvH merged commit 9254a8d into LibreELEC:master Aug 2, 2019

MilhouseVH mentioned this pull request Aug 5, 2019

le92 backports (9.1.003) #3734

Merged

MilhouseVH mentioned this pull request Jan 24, 2020

buildsystem: add absolute patch dirs, remove unecessary sub-process, other cleanup #3661

Merged

vpeter4 deleted the jre.m branch December 28, 2022 10:17

		@@ -0,0 +1,2 @@
		# SPDX-License-Identifier: GPL-2.0-or-later
		# Copyright (C) 2016-present Team LibreELEC (https://libreelec.tv)

	# Copyright (C) 2016-present Team LibreELEC (https://libreelec.tv)
	# Copyright (C) 2019-present Team LibreELEC (https://libreelec.tv)

	# SPDX-License-Identifier: GPL-2.0-or-later
	# SPDX-License-Identifier: GPL-2.0

		@@ -0,0 +1,20 @@
		# SPDX-License-Identifier: GPL-2.0
		# Copyright (C) 2018-present Team LibreELEC (https://libreelec.tv)

		@@ -0,0 +1,35 @@
		# SPDX-License-Identifier: GPL-2.0
		# Copyright (C) 2018-present Team LibreELEC (https://libreelec.tv)

jre.zulu: initial addon #3653

jre.zulu: initial addon #3653

Conversation

vpeter4 commented Jul 5, 2019

MilhouseVH commented Jul 5, 2019

vpeter4 commented Jul 5, 2019

vpeter4 commented Jul 5, 2019

chewitt commented Jul 5, 2019

MilhouseVH commented Jul 6, 2019

CvH left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vpeter4 commented Jul 6, 2019

MilhouseVH commented Jul 7, 2019 • edited Loading

Command line:

MilhouseVH commented Jul 7, 2019

MilhouseVH commented Jul 7, 2019

vpeter4 commented Jul 7, 2019 • edited Loading

MilhouseVH commented Jul 7, 2019

MilhouseVH commented Jul 8, 2019

MilhouseVH commented Jul 8, 2019

vpeter4 commented Jul 8, 2019 • edited Loading

MilhouseVH commented Jul 8, 2019

vpeter4 commented Jul 8, 2019

vpeter4 commented Jul 8, 2019

MilhouseVH commented Jul 8, 2019 • edited Loading

Edit:

MilhouseVH commented Jul 8, 2019

vpeter4 commented Jul 8, 2019

vpeter4 commented Jul 8, 2019 • edited Loading

MilhouseVH commented Aug 2, 2019 • edited Loading

vpeter4 commented Aug 2, 2019

vpeter4 commented Aug 3, 2019

MilhouseVH commented Aug 5, 2019

vpeter4 commented Aug 5, 2019

MilhouseVH commented Jul 7, 2019 •

edited

Loading

vpeter4 commented Jul 7, 2019 •

edited

Loading

vpeter4 commented Jul 8, 2019 •

edited

Loading

MilhouseVH commented Jul 8, 2019 •

edited

Loading

vpeter4 commented Jul 8, 2019 •

edited

Loading

MilhouseVH commented Aug 2, 2019 •

edited

Loading