This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Swift 3.0 API Guidelines Pass 1 #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses better Swift 3 naming for the `path` methods.
|
Closing to re-open against |
|
Shouldn't it be opened against |
|
Heh, yeah that’s what I meant (#132) 🙈 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begins work on API renaming as part of #123
📝 This PR is pointed at
swift-3.0-beta-1-migration, which is in PR at #127. There’s still more to do, but opening this now for feedback. Once #127 gets merged, I’ll close and reopen againstswift-3.0.These are all manual edits made to API names (and a bit of refactoring where appropriate). That is to say, none of this work was performed by the migrator. Migration occurred in #127.
Related: