This repository has been archived by the owner on Oct 21, 2022. It is now read-only.
limited compatibility with IPython 3.2 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smason Thanks for the PR. @hayd @UnknownProgrammer Would you mind reviewing this change? |
|
Huh, iPython 4 has just been released! May be worth doing the proper things now? |
|
@smason If you can help me test your changes, or I can find others to do so, I'll gladly merge PRs to "do the proper things". Let me know how I can help. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been struggling with iPython 3.2 compatibility and have tracked it down to the changed difference:
executeisn't an attribute of theshell_channel.Seems that since the Jupyter/IPython division
ipykernelshould be used instead, but this change gets it sort of working.