-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centralize rank_zero_only utilities into their own module #11747
Merged
akihironitta
merged 15 commits into
Lightning-AI:master
from
ananthsub:refactor/rank-zero
Feb 7, 2022
Merged
Centralize rank_zero_only utilities into their own module #11747
akihironitta
merged 15 commits into
Lightning-AI:master
from
ananthsub:refactor/rank-zero
Feb 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananthsub
commented
Feb 5, 2022
ananthsub
requested review from
awaelchli,
Borda,
carmocca,
edenlightning,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
SkafteNicki,
tchaton and
williamFalcon
as code owners
February 5, 2022 00:32
justusschock
approved these changes
Feb 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Borda
approved these changes
Feb 5, 2022
awaelchli
approved these changes
Feb 5, 2022
ananthsub
force-pushed
the
refactor/rank-zero
branch
from
February 5, 2022 16:23
c1d814f
to
edc73ba
Compare
rohitgr7
reviewed
Feb 5, 2022
rohitgr7
approved these changes
Feb 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
akihironitta
approved these changes
Feb 7, 2022
tchaton
approved these changes
Feb 7, 2022
carmocca
reviewed
Feb 7, 2022
12 tasks
8 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #11746
This simplifies #11725
rank_zero.py
for these utilitiesDoes your PR introduce any breaking changes? If yes, please list them.
No
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃