Skip to content

Conversation

@akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Apr 22, 2022

What does this PR do?

Completes #11747.

pytest caught this missed deprecation warning in #12373 where I'm trying to upgrade the PyTorch version used in GPU CI.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @tchaton @rohitgr7

@akihironitta akihironitta added bug Something isn't working deprecation Includes a deprecation labels Apr 22, 2022
@akihironitta akihironitta added this to the 1.6.x milestone Apr 22, 2022
@mergify mergify bot added the ready PRs ready to be merged label Apr 22, 2022
@akihironitta akihironitta enabled auto-merge (squash) April 22, 2022 16:53
@akihironitta akihironitta requested a review from a team April 23, 2022 00:57
@akihironitta akihironitta merged commit afd2025 into master Apr 24, 2022
@akihironitta akihironitta deleted the bugfix/use-new-rank-zero branch April 24, 2022 21:46
otaj pushed a commit that referenced this pull request Apr 25, 2022
…12846)

* Use new rank_zero_debug

* Fix and move import statement to the top
lexierule pushed a commit that referenced this pull request Apr 27, 2022
…12846)

* Use new rank_zero_debug

* Fix and move import statement to the top
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working deprecation Includes a deprecation ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants