Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes arguments passed to
TemporaryDirectory
that assumes thatcwd
is writable.This means that
tmp_dir
will probably be create in/tmp
, which should work for all use cases.I found another instance of
TemporaryDirectory
called withdir=os.getcwd()
, which I think will lead to similar issue. I'm happy to fix it if that is preferred.pytorch-lightning/src/lightning/pytorch/profilers/advanced.py
Lines 92 to 100 in bd9d114
Fixes #20641
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20642.org.readthedocs.build/en/20642/