Skip to content

Conversation

craigpfeifer
Copy link
Contributor

@craigpfeifer craigpfeifer commented Apr 10, 2025

What does this PR do?

Modified the message to specify the package to install and benefit of use

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20707.org.readthedocs.build/en/20707/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Apr 10, 2025
Copy link
Contributor

github-actions bot commented Apr 10, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success
pytorch-lightning (GPUs) (testing PyTorch | latest) success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py.

🟢 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py.

🟢 install
Check ID Status
install-pkg-guardian success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79%. Comparing base (cd785a4) to head (041a89d).
Report is 134 commits behind head on master.

✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (cd785a4) and HEAD (041a89d). Click for more details.

HEAD has 576 uploads less than BASE
Flag BASE (cd785a4) HEAD (041a89d)
cpu 156 27
python 13 3
lightning_fabric 36 0
pytest 81 0
python3.10 36 6
python3.12.7 53 9
python3.12 18 3
lightning 90 15
python3.11 36 6
gpu 3 0
pytorch2.1 15 6
pytorch_lightning 33 12
pytest-full 78 27
pytorch2.2.2 9 3
pytorch2.3 9 3
pytorch2.5 9 3
pytorch2.4.1 9 3
pytorch2.7 9 3
pytorch2.6 9 3
pytorch2.5.1 9 3
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #20707     +/-   ##
=========================================
- Coverage      87%      79%     -8%     
=========================================
  Files         268      265      -3     
  Lines       23449    23394     -55     
=========================================
- Hits        20389    18386   -2003     
- Misses       3060     5008   +1948     

@craigpfeifer craigpfeifer merged commit 4281b58 into master Apr 10, 2025
83 checks passed
@craigpfeifer craigpfeifer deleted the craig/litmodel-message branch April 10, 2025 20:58
Borda added a commit that referenced this pull request Apr 25, 2025
* making litmodels message clearer

* linter

---------

Co-authored-by: Jirka B <j.borovec+github@gmail.com>
(cherry picked from commit 4281b58)
Borda added a commit that referenced this pull request Apr 25, 2025
* making litmodels message clearer

* linter

---------

Co-authored-by: Jirka B <j.borovec+github@gmail.com>
(cherry picked from commit 4281b58)
lexierule pushed a commit that referenced this pull request Apr 25, 2025
* making litmodels message clearer

* linter

---------

Co-authored-by: Jirka B <j.borovec+github@gmail.com>
(cherry picked from commit 4281b58)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants