Skip to content

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Apr 22, 2025

What does this PR do?

remove false failing check for dryrun when uploading legacy checkpoint helps navigate what PRs are ready to land which need some more care

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20745.org.readthedocs.build/en/20745/

@Borda Borda requested a review from Copilot April 22, 2025 09:51
@github-actions github-actions bot added the ci Continuous Integration label Apr 22, 2025
Copy link
Contributor

⚡ Required checks status: All passing 🟢

No groups match the files changed in this PR.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adjusts the legacy checkpoints workflow to suppress false failing checks for legacy checkpoint creation by modifying the dryrun command.

  • Updated the AWS_RUN environment variable command to include the region flag along with the dryrun option when push_to_s3 is false.
Comments suppressed due to low confidence (1)

.github/workflows/_legacy-checkpoints.yml:104

  • Ensure that the addition of the '--region us-east-1' flag does not inadvertently change the intended behavior of the dryrun check in other parts of the workflow. If this is a temporary suppression, consider adding documentation or a comment to clarify the rationale for including the region flag.
python -c "print('AWS_RUN=' + str('' if '${{inputs.push_to_s3}}' == 'true' else '--region us-east-1 --dryrun'))" >> $GITHUB_ENV

@Borda Borda merged commit 08a04de into master Apr 22, 2025
13 checks passed
@Borda Borda deleted the ci/ckpt-fix branch April 22, 2025 09:57
Borda added a commit that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants