Skip to content

Conversation

bhimrazy
Copy link
Collaborator

@bhimrazy bhimrazy commented Aug 21, 2025

What does this PR do?

Closes #18282

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21103.org.readthedocs.build/en/21103/

@bhimrazy bhimrazy self-assigned this Aug 21, 2025
@bhimrazy bhimrazy requested a review from lantiga as a code owner August 21, 2025 10:12
@bhimrazy bhimrazy added the docs Documentation related label Aug 21, 2025
@bhimrazy bhimrazy added the logging Related to the `LoggerConnector` and `log()` label Aug 21, 2025
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 21, 2025
@bhimrazy bhimrazy requested a review from SkafteNicki August 21, 2025 10:13
@bhimrazy
Copy link
Collaborator Author

bhimrazy commented Aug 21, 2025

Link issue seems to come from

adjust_linked_external_docs(
"https://lightning.ai/docs/torchmetrics", "https://lightning.ai/docs/torchmetrics/v{torchmetrics.__version__}/", _PATH_ROOT, version_digits=3
)

Ideally I think it should be https://lightning.ai/docs/torchmetrics/stable/

@Borda Borda merged commit 571310f into Lightning-AI:master Aug 21, 2025
20 of 21 checks passed
@bhimrazy bhimrazy deleted the docs/update-logging-with-torchmetrics-docs branch August 21, 2025 12:00
Borda pushed a commit that referenced this pull request Aug 28, 2025
lantiga pushed a commit that referenced this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related logging Related to the `LoggerConnector` and `log()` pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics not being reset in-between multiple dataloaders during validation.
3 participants