Skip to content

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Aug 28, 2025

What does this PR do?

This is already in requirements file, so duplication may bring confusion for an user when he checks how to install tests

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21127.org.readthedocs.build/en/21127/

@github-actions github-actions bot added the ci Continuous Integration label Aug 28, 2025
Copy link
Contributor

github-actions bot commented Aug 28, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success

These checks are required after the changes to requirements/pytorch/test.txt.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success
pytorch-lightning (GPUs) (testing PyTorch | oldest) success
pytorch-lightning (GPUs) (testing PyTorch | latest) success

These checks are required after the changes to requirements/pytorch/test.txt.

🟢 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks success

These checks are required after the changes to requirements/pytorch/test.txt.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to requirements/pytorch/test.txt.

🟢 pytorch_lightning: Docker
Check ID Status
build-cuda (3.10, 2.1.2, 12.1.1) success
build-cuda (3.11, 2.2.2, 12.1.1) success
build-cuda (3.11, 2.3.1, 12.1.1) success
build-cuda (3.11, 2.4.1, 12.1.1) success
build-cuda (3.12, 2.5.1, 12.1.1) success
build-cuda (3.12, 2.6.0, 12.4.1) success
build-pl (3.10, 2.1, 12.1.1) success
build-pl (3.11, 2.2, 12.1.1) success
build-pl (3.11, 2.3, 12.1.1) success
build-pl (3.11, 2.4, 12.1.1) success
build-pl (3.12, 2.5, 12.1.1) success
build-pl (3.12, 2.6, 12.4.1) success
build-pl (3.12, 2.7, 12.6.3) success
build-pl (3.12, 2.8, 12.6.3, true) success

These checks are required after the changes to requirements/pytorch/test.txt.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to requirements/pytorch/test.txt.

🟢 install
Check ID Status
install-pkg-guardian success

These checks are required after the changes to requirements/pytorch/test.txt.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79%. Comparing base (691f084) to head (3b14525).
⚠️ Report is 3 commits behind head on master.
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (691f084) and HEAD (3b14525). Click for more details.

HEAD has 117 uploads less than BASE
Flag BASE (691f084) HEAD (3b14525)
cpu 54 27
python 6 3
lightning_fabric 14 0
pytest 30 0
lightning 31 15
python3.11 12 6
python3.12 6 3
python3.10 12 6
python3.12.7 18 9
gpu 3 0
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #21127     +/-   ##
=========================================
- Coverage      87%      79%     -8%     
=========================================
  Files         269      266      -3     
  Lines       23520    23465     -55     
=========================================
- Hits        20505    18486   -2019     
- Misses       3015     4979   +1964     

@github-actions github-actions bot added pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels Aug 29, 2025
@Borda Borda merged commit 634e6e6 into master Aug 29, 2025
110 of 112 checks passed
@Borda Borda deleted the ci/req branch August 29, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration dependencies Pull requests that update a dependency file pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants