Skip to content

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Aug 29, 2025

What does this PR do?

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21130.org.readthedocs.build/en/21130/

@github-actions github-actions bot added ci Continuous Integration dockers labels Aug 29, 2025
Copy link
Contributor

github-actions bot commented Aug 29, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Docker
Check ID Status
build-cuda (3.10, 2.1.2, 12.1.1) success
build-cuda (3.11, 2.2.2, 12.1.1) success
build-cuda (3.11, 2.3.1, 12.1.1) success
build-cuda (3.11, 2.4.1, 12.1.1) success
build-cuda (3.12, 2.5.1, 12.1.1) success
build-cuda (3.12, 2.6.0, 12.4.1) success
build-pl (3.10, 2.1, 12.1.1) success
build-pl (3.11, 2.2, 12.1.1) success
build-pl (3.11, 2.3, 12.1.1) success
build-pl (3.11, 2.4, 12.1.1) success
build-pl (3.12, 2.5, 12.1.1) success
build-pl (3.12, 2.6, 12.4.1) success
build-pl (3.12, 2.7, 12.6.3) success
build-pl (3.12, 2.8, 12.6.3, true) success

These checks are required after the changes to dockers/base-cuda/Dockerfile.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda changed the title debug: missing nvcc on images with pt-2.1 debug: resolve failing tests with pt-2.1 Aug 29, 2025
@Borda Borda changed the title debug: resolve failing tests with pt-2.1 resolve failing tests with pt-2.1 Aug 29, 2025
@Borda Borda merged commit d85c474 into master Aug 29, 2025
38 checks passed
@Borda Borda deleted the ci/lit branch August 29, 2025 22:20
Borda added a commit that referenced this pull request Sep 3, 2025
* pip uninstall -y deepspeed
* TORCH_VER
* Apply suggestions from code review
* A100 & L4
* machine

(cherry picked from commit d85c474)
lantiga pushed a commit that referenced this pull request Sep 5, 2025
* pip uninstall -y deepspeed
* TORCH_VER
* Apply suggestions from code review
* A100 & L4
* machine

(cherry picked from commit d85c474)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration dockers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants