-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New wrapper FeatureShare
#2120
Merged
Merged
New wrapper FeatureShare
#2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Nov 29, 2023
SkafteNicki
requested review from
lantiga,
Borda,
justusschock and
stancld
as code owners
November 29, 2023 08:56
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2120 +/- ##
========================================
- Coverage 87% 47% -40%
========================================
Files 300 303 +3
Lines 16971 17059 +88
========================================
- Hits 14737 7991 -6746
- Misses 2234 9068 +6834 |
Borda
approved these changes
Nov 30, 2023
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
for more information, see https://pre-commit.ci
stancld
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
ready
topic: Image
topic: MModal
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2099
Introduces a new wrapper
FeatureShare
that is intended to be used with metrics that uses some underlying neural network to do their calculation. As pointed out in the issue it is a waste of memory that the same network that can be shared between networks gets initialized multiple times and that the computations in not reused.Work in progress...
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2120.org.readthedocs.build/en/2120/