This repository was archived by the owner on Aug 28, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 80
Add Flash Question Answering tutorial #125
Closed
karthikrangasai
wants to merge
11
commits into
Lightning-AI:main
from
karthikrangasai:add_flash_tutorial_question_answering
Closed
Add Flash Question Answering tutorial #125
karthikrangasai
wants to merge
11
commits into
Lightning-AI:main
from
karthikrangasai:add_flash_tutorial_question_answering
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
reviewed
Dec 16, 2021
# First, download the data: | ||
|
||
# %% | ||
download_data("https://pl-flash-data.s3.amazonaws.com/kaggle_chaii.zip", DATASET_PATH) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's move this to meta-file
Suggested change
download_data("https://pl-flash-data.s3.amazonaws.com/kaggle_chaii.zip", DATASET_PATH) |
then we can even skip this cell :]
Borda
reviewed
Dec 30, 2021
@karthikrangasai mind checking the failing tests? :] |
…b.com/karthikrangasai/lightning-tutorials into add_flash_tutorial_question_answering
@karthikrangasai could you pls remind me what I have promised here to do to unblock it? 🐰 |
Hello @Borda , We had spoken about
Downloading and sharing the dataset again might have licensing issues. After this, I don't think we had arrived to a conclusive solution. |
acdd659
to
0bb4a7e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
===================================
Coverage 73% 73%
===================================
Files 2 2
Lines 382 382
===================================
Hits 280 280
Misses 102 102 |
just re-generated Key and the same issue, also check that the user approved dataset conditions... need to check deeper |
d4acf6f
to
ac8f7ba
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes # (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃