This repository was archived by the owner on Aug 28, 2025. It is now read-only.
update broken gan/datamodules tutorial links #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speediedan
requested review from
Borda,
SeanNaren,
carmocca,
ethanwharris and
kaushikb11
as code owners
Codecov Report
@@ Coverage Diff @@
## main #164 +/- ##
===================================
Coverage 75% 75%
===================================
Files 2 2
Lines 370 370
===================================
Hits 276 276
Misses 94 94 |
Borda
reviewed
Apr 21, 2022
… link on publication branch: https://github.com/PyTorchLightning/lightning-tutorials/blob/publication/.notebooks/lightning_examples/datamodules.ipynb?short_path=646984d#L24) and update datamodules doc link to latest
speediedan
changed the title
@Borda makes sense, I've gone ahead and triggered an update to the datamodules tutorial too since the merge with the publication branch was causing a stale link to be introduced. All checks are passing now again. |
speediedan
force-pushed
the
stale_gan_link
branch
from
4988ece to
04ef188
Compare
speediedan
force-pushed
the
stale_gan_link
branch
from
04ef188 to
38fc269
Compare
Borda
approved these changes
Apr 21, 2022
Borda
added a commit
that referenced
this pull request
Apr 22, 2022
* update both datamodules and basic-gan tutorials to reference stable doc version * fix show progress Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Borda
added a commit
that referenced
this pull request
Apr 22, 2022
* update both datamodules and basic-gan tutorials to reference stable doc version * fix show progress Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
(doc improvement)
What does this PR do?
Fixes # broken link in gan tutorial
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃