Skip to content

feat: add firefish button #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 13, 2023
Merged

feat: add firefish button #564

merged 4 commits into from
Sep 13, 2023

Conversation

LeviSnoot
Copy link
Contributor

image

Firefish also uses rel="me" for verification so I pretty much copied the code for Mastodon. Lemme know if something's wrong.

@JulianPrieber
Copy link
Member

Someone used the thing!

@JulianPrieber
Copy link
Member

@LeviSnoot do we need a separate @case('firefish') for this?

@JulianPrieber
Copy link
Member

If we now have multiple rel me thingies, we might want to implement somehting like this:

@php
  $relMe = "mastodon, firefish";
  $relMeList = explode(', ', $relMe);
@endphp

@foreach($links as $link)
  @if(in_array($link->name, $relMeList))
    <link href="{{$link->link}}" rel="me">
  @endif
@endforeach

@JulianPrieber JulianPrieber self-assigned this Sep 12, 2023
@LeviSnoot
Copy link
Contributor Author

@LeviSnoot do we need a separate @case('firefish') for this?

@JulianPrieber No. I'm not read up on PHP at all but it seems like the code you suggested did what we wanted:
image

If this looks good to you I'll pull it to this PR.

https://github.com/LeviSnoot/LinkStack/blob/1dbd7a2d6505d9b4c44c0111e0209f1134ce4856/resources/views/littlelink.blade.php#L8-L18

@JulianPrieber
Copy link
Member

@JulianPrieber
Copy link
Member

Gotta test this but if it works we'll merge it as is

fix: group fediverse "relMe" function
@MagicLike
Copy link
Member

tagging @ThatOneCalculator

@MagicLike MagicLike added enhancement New feature or request button New or updated buttons labels Sep 12, 2023
@ThatOneCalculator
Copy link

Nice!!

@JulianPrieber JulianPrieber merged commit cefd28a into LinkStackOrg:main Sep 13, 2023
@JulianPrieber
Copy link
Member

87aa73e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
button New or updated buttons enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants