Allow "Connection established" in check_reason #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems proxy.py use "Connection established" instead. https://github.com/abhinavsingh/proxy.py/blob/c09fc8627727fed98dd1bdde8321a6efa36a8fcd/proxy/http/proxy/server.py#L106
|
Thanks for your contribution. There is no specific reason, why there is the check. I only want to be sure that the connection was established. |
|
Could you fix the formatting, please? |
It's a bit beyond this PR but can we change the logic? For example, just check the status code. |
|
Sure, remove the function |
lambdalisue
added a commit
to lambdalisue/async-http-proxy
that referenced
this pull request
Jun 4, 2021
See LinkTed#1 for the background.
|
I made a new PR #2 which remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for the library.
I've tried this with proxy.py and I've found that it seems the message is "Connection established" rather than "Connection Established" at least for proxy.py.
https://github.com/abhinavsingh/proxy.py/blob/c09fc8627727fed98dd1bdde8321a6efa36a8fcd/proxy/http/proxy/server.py#L106
Additionally, I wonder why you check the message string itself. I feel it's a bit fragile so could you tell me the reason for this?