Skip to content

Servlet now completely agnostic of the type of LDFs requested #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 16, 2015

Conversation

hartig
Copy link
Contributor

@hartig hartig commented Dec 15, 2015

As promised in #18 (comment), this PR provides everything to make the servlet completely agnostic of the type of LDFs that the data source supports.

hartig and others added 3 commits December 15, 2015 15:10
merging in latest changes from origin
…est, ConfigReader)', which makes the servlet completely agnostic of the specific type of LDF supported
@mielvds
Copy link
Contributor

mielvds commented Dec 15, 2015

It probably shouldn't be called TriplePatternFragmentServlet anymore I guess. Aren't you tying everything to the datasource now?

@hartig
Copy link
Contributor Author

hartig commented Dec 15, 2015

@mielvds You are right; it really is a LinkedDataFragmentServlet now. I will rename it and push a commit into this PR.

@RubenVerborgh I know; I am also only "medium-happy" with it. But, as you say, it is already quite an improvement over the existing, TPF-only focused implementation approach. Moreover, note that the actual implementations of the IDataSource interface do not have to deal with the HTTP requests because this is already covered by AbstractRequestProcessorForTriplePatterns. Another thing that I should emphasize in this context is that AbstractRequestProcessorForTriplePatterns uses the intermediate method createFragment(String, String, String, long, long) on purpose. This can be overridden in request processors / data source implementations that are not based on Jena and, thus, it allows for avoiding the overhead of having to i) generate Jena objects and ii) transforming them into some other representation that the backend understands (e.g., Sesame objects).

@RubenVerborgh
Copy link
Member

@hartig I'm more than medium happy 😉 Great job!

@hartig
Copy link
Contributor Author

hartig commented Dec 15, 2015

@mielvds OK, renaming done.

@RubenVerborgh ;-)

… better to simply return an empty StmtIterator instead of repeatedly creating an empty Jena Model and asking it for a StmtIterator
mielvds pushed a commit that referenced this pull request Dec 16, 2015
Servlet now completely agnostic of the type of LDFs requested
@mielvds mielvds merged commit c36ee58 into LinkedDataFragments:master Dec 16, 2015
@hartig hartig deleted the GenericServlet branch December 16, 2015 10:18
@hartig hartig mentioned this pull request Dec 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants