Load data source types based on config file #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merging in latest changes from origin
…ions in the config file
…SourceType implementations as given in the config file
mielvds
pushed a commit
that referenced
this pull request
Dec 26, 2015
Load data source types based on config file
|
Perhaps, we should have consistent naming for interfaces. I started with the I convention, but have no real preference. |
|
@mielvds Thanks for merging this PR. I agree, a consistent naming of interfaces would be good (and I do not have any preference either) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the possibility to specify relevant IDataSourceType implementations in the config file. As a result, it is now possible to directly integrate additional code for other backends or other types of LDFs. All that needs to be done is to link in an additional JAR with the additional data source and specify the corresponding IDataSourceType implementations in the config file.
This should be the last PR of my refactoring efforts.