Skip to content

Formatting and upgrades #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

barthanssens
Copy link
Contributor

Some indentation fixes, library upgrades (Jetty, Gson...) and removal of superfluous "final"

@RubenVerborgh
Copy link
Member

Thanks, @barthanssens, will have a look at this. Note that the final is always on purpose, to indicate that the variable will not be modified. But we can indeed do without.

@barthanssens
Copy link
Contributor Author

Meanwhile I'm reworking the code a little bit. If all goes well, I'll try to add a Jena datasource.

@mielvds
Copy link
Contributor

mielvds commented Dec 1, 2015

Thanks for the help! Agreed that the final statements were a bit overdone.

Could you specify the changes you're planning to make in a separate issue? I was, for instance, planning to have a look at content negotiation.

@barthanssens
Copy link
Contributor Author

Ok, I'll close this one and create one or two separate issues :-)
I was working on some refactoring in the servlet (making it a bit more readable) and adding a Jena datasource

@mielvds
Copy link
Contributor

mielvds commented Dec 1, 2015

We should still merge this right? @RubenVerborgh?

@barthanssens
Copy link
Contributor Author

I'll make another pull request, including your changes on content negotiation.

mielvds pushed a commit that referenced this pull request Dec 23, 2015
merging in latest changes from origin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants