Hotfix/movement status (w/ signed-off-by) #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpHandleEmptyQueue now explicitly sets status flags in tp and emcmotStatus to the appropriate defaults. This should prevent spurious non-zero values from appearing in current_vel and similar status fields when the motion queue is empty. This was likely an overlooked regression from 2.6 due to the major refactor introduced with the new trajectory planner. Signed-off-by: Robert W. Ellenberg <rwe24g@gmail.com>
…IO is not disrupted Signed-off-by: Robert W. Ellenberg <rwe24g@gmail.com>
|
Merged. Thanks for the fixes. |
robEllenberg
pushed a commit
to robEllenberg/linuxcnc-mirror
that referenced
this pull request
Aug 25, 2015
2c88c39 Merge pull request LinuxCNC#13 from strahlex/mklauncher4 3afd7aa updating definitions for mklauncher 30ba664 added none to motion type to work with mkwrapper 0fa4107 updated mklauncher definitions 3a015e3 using index field for mklauncher 18e2954 updated definition for mklauncher 2a36b25 added definitions for mklauncher c950308 fix missing msgid in value.proto f9a759a Merge pull request LinuxCNC#12 from mhaberler/master 0a01fd2 object: add Vtable, Inst descriptions and msgid's 8ae9f49 HAL instantiation: update to new HAL objects, instance-related commands 9f35d82 proto definitions: add unique msgd options 9a4e3e0 README.msgid - about protobuf type id's and their usage 4f854b3 README.style: remove obsolete file d281116 nanopb.proto: bring in msgid changes from nanopb upstream 118f0e3 Merge pull request LinuxCNC#11 from mhaberler/prune-messages-for-nanopb 0674348 nanopb.proto: update to nanopb-0.3.2 5167bcb Merge pull request LinuxCNC#10 from mhaberler/prune-messages-for-nanopb 90beece message.proto: do not export mkwrapper messages to nanopb/RT git-subtree-dir: src/machinetalk/proto git-subtree-split: 2c88c39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tpHandleEmptyQueue now explicitly sets status flags in tp and
emcmotStatus to the appropriate defaults. This should prevent spurious
non-zero values from appearing in current_vel and similar status fields
when the motion queue is empty. This was likely an overlooked regression
from 2.6 due to the major refactor introduced with the new trajectory
planner.