Skip to content

Fixing access specifiers on exceptions, removed unused exception #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2023
Merged

Fixing access specifiers on exceptions, removed unused exception #10

merged 1 commit into from
Jan 9, 2023

Conversation

LinuxDevon
Copy link
Owner

Fixing the public specifier issue on the exceptions. Removed the unused header_error not sure why that was there.

@LinuxDevon
Copy link
Owner Author

Should fix your comment in #2 @Murmele. Let me know what you think

@Murmele
Copy link
Contributor

Murmele commented Jan 7, 2023

@LinuxDevon looks good to me

@LinuxDevon LinuxDevon merged commit 44a4a72 into master Jan 9, 2023
@LinuxDevon LinuxDevon deleted the fix-access-specifiers-for-exceptions branch January 9, 2023 22:58
@LinuxDevon LinuxDevon mentioned this pull request Jan 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Murmele Murmele Murmele approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LinuxDevon @Murmele