issue #3390 - whole-system interactions honor resources config #3473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmsurpre
force-pushed
the
issue-3390
branch
2 times, most recently
from
63d1d19
to
c142954
Compare
* Introduce the ResourceTypeName enum in fhir-core and ResourcesConfigAdapter in fhir-config * Use ResourcesConfigAdapter from whole-system search, whole-system history, $everything, and $export I also started on #3319 - system-search now supports multiple instances of the `_type` parameter Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
force-pushed
the
issue-3390
branch
4 times, most recently
from
1144101
to
6e5c77f
Compare
For Group/$export, this changeset restores a line I had accidentally deleted which sets the Group.id for Group export. For Patient/$everything, now that we're properly reading the fhir-server-config, we need to adjust the tenant1 configuration so that all resource types that actually get used are in the config so that we can set `open` to false. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
changed the title
tbieste
approved these changes
Mar 17, 2022
lmsurpre
force-pushed
the
issue-3390
branch
4 times, most recently
from
10acf91
to
0ea1c63
Compare
twice Now that the Patient resource is in its own compartment, we don't need to add that resource to the result set separately any more. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
commented
Mar 31, 2022
| import com.ibm.fhir.core.ResourceTypeName; | ||
|
|
||
| /** | ||
| * An abstraction for the ibm-fhir-server fhirServer/resources property group |
There was a problem hiding this comment.
indicate that we should create a new instance of this for each request (at least). otherwise the property lookups won't be dynamic when retrieved through here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also started on #3319 - system-search now supports multiple instances of the
_typeparameterAlso a small fix for #3091
Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com