This repository has been archived by the owner on Mar 12, 2019. It is now read-only.
pull: Fix fetching of x86_64_linux bottles #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the tap you're pulling from includes "Linuxbrew" in its name and the formula has an x86_64_linux bottle, use that one. Otherwise, fall back to Homebrew's default behaviour.
| @@ -516,7 +516,11 @@ def verify_bintray_published(formulae_names) | |||
| opoo "Cannot publish bottle: Failed reading info for formula #{f.full_name}" | |||
| next | |||
| end | |||
| bottle_info = jinfo.bottle_info(jinfo.bottle_tags.first) | |||
| if f.tap.remote.include?("Linuxbrew") && jinfo.bottle_tags.include?("x86_64_linux") | |||
There was a problem hiding this comment.
This incantation of f.tap.remote.include?("Linuxbrew") has come up a few times now. Would you like to factor out a tap.linux? function? It can be done in its own PR either before or after this PR as you see fit.
There was a problem hiding this comment.
Agreed that it'd be nice. Will spin off its own issue for it though, since otherwise I'd be changing a lot more stuff on this PR than I'd like to.
EDIT: spun off as #18
|
Thanks for the fix! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew testswith your changes locally?If the tap you're pulling from includes "Linuxbrew" in its name and the formula has an x86_64_linux bottle, use that one. Otherwise, fall back to Homebrew's default behaviour.
Previously, we were verifying by downloading the first bottle in the list, but since that's usually a Mac bottle, the download will fail.